fix: emit status to stdout #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
requested review from
rach-id and
ninabarbakadze
and removed request for
a team
cmwaters
approved these changes
Nov 29, 2024
|
If I may (sounds like the same issue Osmosis had), you should probably set the default output in your app instead: https://github.com/cosmos/cosmos-sdk/blob/v0.50.10/simapp/simd/cmd/root.go#L52-L54
The SDK is using |
|
Thanks for the review @julienrbrt ! Good idea, will do that in celestia-app and close this PR. |
rootulp
added a commit
to celestiaorg/celestia-app
that referenced
this pull request
Dec 3, 2024
Closes #3823 Motivation celestiaorg/cosmos-sdk#420 (comment) ## Testing ```bash make build ./build/celestia-appd status | jq . ``` works
mergify bot
pushed a commit
to celestiaorg/celestia-app
that referenced
this pull request
Dec 3, 2024
Closes #3823 Motivation celestiaorg/cosmos-sdk#420 (comment) ## Testing ```bash make build ./build/celestia-appd status | jq . ``` works (cherry picked from commit 615f1dc)
rootulp
added a commit
to celestiaorg/celestia-app
that referenced
this pull request
Dec 4, 2024
Closes #3823 Motivation celestiaorg/cosmos-sdk#420 (comment) ## Testing ```bash make build ./build/celestia-appd status | jq . ``` works <hr>This is an automatic backport of pull request #4071 done by [Mergify](https://mergify.com). Co-authored-by: Rootul P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of celestiaorg/celestia-app#3823
Testing
After building a celestia-app binary that replaces cosmos-sdk with this, that status output goes to stdout so it can be piped to jq easily. In other words, this works: